Skip to content

Release 0.0.1 to develop#62

Merged
DongChyeon merged 6 commits intodevelopfrom
release/0.0.1
Feb 25, 2026
Merged

Release 0.0.1 to develop#62
DongChyeon merged 6 commits intodevelopfrom
release/0.0.1

Conversation

@DongChyeon
Copy link
Member

@DongChyeon DongChyeon commented Feb 25, 2026

๐Ÿ›  Related issue

closed #<issue_number>

์–ด๋–ค ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์žˆ์—ˆ๋‚˜์š”?

  • ๐Ÿž BugFix Something isn't working
  • ๐ŸŽจ Design Markup & styling
  • ๐Ÿ“ƒ Docs Documentation writing and editing (README.md, etc.)
  • โœจ Feature Feature
  • ๐Ÿ”จ Refactor Code refactoring
  • โš™๏ธ Setting Development environment setup
  • โœ… Test Test related (Junit, etc.)

โœ… CheckPoint

PR์ด ๋‹ค์Œ ์š”๊ตฌ ์‚ฌํ•ญ์„ ์ถฉ์กฑํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

  • PR ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค. (ํ•„์ˆ˜)
  • mergeํ•  ๋ธŒ๋žœ์น˜์˜ ์œ„์น˜๋ฅผ ํ™•์ธํ•ด ์ฃผ์„ธ์š”(mainโŒ/developโญ•) (ํ•„์ˆ˜)
  • Approve๋œ PR์€ assigner๊ฐ€ ๋จธ์ง€ํ•˜๊ณ , ์ˆ˜์ • ์š”์ฒญ์ด ์˜จ ๊ฒฝ์šฐ ์ˆ˜์ • ํ›„ ๋‹ค์‹œ push๋ฅผ ํ•ฉ๋‹ˆ๋‹ค. (ํ•„์ˆ˜)
  • BugFix์˜ ๊ฒฝ์šฐ, ๋ฒ„๊ทธ์˜ ์›์ธ์„ ํŒŒ์•…ํ•˜์˜€์Šต๋‹ˆ๋‹ค. (์„ ํƒ)

โœ๏ธ Work Description

  • ์ž‘์—… ๋‚ด์šฉ

๐Ÿ˜… Uncompleted Tasks

  • Task1

๐Ÿ“ข To Reviewers

๐Ÿ“ƒ RCA ๋ฃฐ

  • R: ๊ผญ ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š”. ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด ์ฃผ์„ธ์š”. (Request changes)
  • C: ์›ฌ๋งŒํ•˜๋ฉด ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š”. (Comment)
  • A: ๋ฐ˜์˜ํ•ด๋„ ์ข‹๊ณ  ๋„˜์–ด๊ฐ€๋„ ์ข‹์Šต๋‹ˆ๋‹ค. ๊ทธ๋ƒฅ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค. (Approve)

Summary by CodeRabbit

๋ฆด๋ฆฌ์Šค ๋…ธํŠธ

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ

    • ์•ฑ ์•ˆ์ •์„ฑ ํ–ฅ์ƒ์„ ์œ„ํ•œ ์ถฉ๋Œ ๋ณด๊ณ  ๊ธฐ๋Šฅ ์ถ”๊ฐ€
    • ์—…๋กœ๋“œ ํ™”๋ฉด์—์„œ ์ž…๋ ฅ ์‚ฌํ•ญ์ด ์žˆ์„ ๋•Œ ๋’ค๋กœ ๊ฐ€๊ธฐ ๋ฒ„ํŠผ ํ™•์ธ ๋ฉ”์‹œ์ง€ ํ‘œ์‹œ
  • ๋ฒ„๊ทธ ์ˆ˜์ •

    • ์‚ฌ์šฉ์ž๊ฐ€ ์ž์‹ ์˜ ๊ฒŒ์‹œ๋ฌผ์— ํˆฌํ‘œํ•˜์ง€ ๋ชปํ•˜๋„๋ก ์ œํ•œ
    • ์ž…๋ ฅ ๋‚ด์šฉ์ด ์—†์„ ๋•Œ ์—…๋กœ๋“œ ํ™”๋ฉด ๋’ค๋กœ ๊ฐ€๊ธฐ ๋™์ž‘ ๊ฐœ์„ 
  • ์„ฑ๋Šฅ ๊ฐœ์„ 

    • ์•ฑ ํฌ๊ธฐ ์ตœ์ ํ™”๋ฅผ ์œ„ํ•œ ๋ฆฌ์†Œ์Šค ์••์ถ• ํ™œ์„ฑํ™”

@DongChyeon DongChyeon merged commit 3f19286 into develop Feb 25, 2026
2 of 3 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

Caution

Review failed

The pull request is closed.

โ„น๏ธ Recent review info

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between c08452f and bc0e855.

๐Ÿ“’ Files selected for processing (12)
  • app/build.gradle.kts
  • app/proguard-rules.pro
  • app/src/main/AndroidManifest.xml
  • app/src/main/java/com/sseotdabwa/buyornot/navigation/BuyOrNotNavHost.kt
  • build.gradle.kts
  • feature/home/src/main/java/com/sseotdabwa/buyornot/feature/home/navigation/HomeNavigation.kt
  • feature/home/src/main/java/com/sseotdabwa/buyornot/feature/home/ui/HomeContract.kt
  • feature/home/src/main/java/com/sseotdabwa/buyornot/feature/home/ui/HomeScreen.kt
  • feature/home/src/main/java/com/sseotdabwa/buyornot/feature/home/ui/HomeViewModel.kt
  • feature/upload/src/main/java/com/sseotdabwa/buyornot/feature/upload/ui/UploadContract.kt
  • feature/upload/src/main/java/com/sseotdabwa/buyornot/feature/upload/ui/UploadScreen.kt
  • gradle/libs.versions.toml

Walkthrough

Firebase Crashlytics ํ”Œ๋Ÿฌ๊ทธ์ธ ๋ฐ ์˜์กด์„ฑ์„ ์ถ”๊ฐ€ํ•˜๊ณ , ์•ฑ ๋ฒ„์ „์„ ์—…๋ฐ์ดํŠธํ–ˆ์Šต๋‹ˆ๋‹ค. ProGuard ๊ทœ์น™์„ ํ™•๋Œ€ํ•˜๊ณ , ๊ถŒํ•œ์„ ์ถ”๊ฐ€ํ•˜๋ฉฐ, HomeTab ํด๋ž˜์Šค๋ฅผ viewmodel์—์„œ ui ํŒจํ‚ค์ง€๋กœ ์ด๋™ํ–ˆ๊ณ , ํˆฌํ‘œ ์†Œ์œ ๊ถŒ ๊ฒ€์ฆ ๋ฐ ์ž…๋ ฅ ๊ธฐ๋ฐ˜ ๋ฐฑ๋ฒ„ํŠผ ์ฒ˜๋ฆฌ ๋กœ์ง์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes

Cohort / File(s) Summary
Firebase ๋ฐ ๋นŒ๋“œ ์„ค์ •
build.gradle.kts, app/build.gradle.kts, gradle/libs.versions.toml
Firebase Crashlytics ํ”Œ๋Ÿฌ๊ทธ์ธ ๋ฐ ์˜์กด์„ฑ ์ถ”๊ฐ€(v3.0.3), FirebaseBOM ๋ฒ„์ „ ์—…๊ทธ๋ ˆ์ด๋“œ(33.9.0โ†’34.9.0), Release ๋นŒ๋“œ์—์„œ minify ๋ฐ shrinkResources ํ™œ์„ฑํ™”, ์•ฑ versionCode(1โ†’2) ๋ฐ versionName("1.0.0"โ†’"0.0.1") ์—…๋ฐ์ดํŠธ.
ProGuard ๊ทœ์น™ ํ™•๋Œ€
app/proguard-rules.pro
Kotlin ๋ฉ”ํƒ€๋ฐ์ดํ„ฐ, Hilt/Dagger, Retrofit, OkHttp, Kotlinx Serialization, Coil, Firebase, Lottie, Kakao SDK, Jetpack Compose ๋“ฑ ์—ฌ๋Ÿฌ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์— ๋Œ€ํ•œ ๋ณด์กด ๊ทœ์น™ ๋ฐ ๊ฒฝ๊ณ  ์–ต์ œ ์ง€์‹œ๋ฌธ ์ถ”๊ฐ€.
๊ถŒํ•œ ๋ฐ Manifest
app/src/main/AndroidManifest.xml
Google Mobile Ads ID ๊ถŒํ•œ(com.google.android.gms.permission.AD_ID) ์ถ”๊ฐ€.
HomeTab ํŒจํ‚ค์ง€ ์ด๋™
app/src/main/java/com/sseotdabwa/buyornot/navigation/BuyOrNotNavHost.kt, feature/home/src/main/java/com/sseotdabwa/buyornot/feature/home/navigation/HomeNavigation.kt, feature/home/src/main/java/com/sseotdabwa/buyornot/feature/home/ui/HomeContract.kt, feature/home/src/main/java/com/sseotdabwa/buyornot/feature/home/ui/HomeScreen.kt
HomeTab ํด๋ž˜์Šค ๋ฐ ๊ด€๋ จ ํƒ€์ž…์„ feature.home.viewmodel์—์„œ feature.home.ui๋กœ ์ด๋™, ํŒจํ‚ค์ง€ ์„ ์–ธ ๋ฐ import ๊ฒฝ๋กœ ์—…๋ฐ์ดํŠธ.
HomeViewModel ํˆฌํ‘œ ๊ฒ€์ฆ
feature/home/src/main/java/com/sseotdabwa/buyornot/feature/home/ui/HomeViewModel.kt
handleVote ๋ฉ”์„œ๋“œ์— ์†Œ์œ ๊ถŒ ๊ฒ€์ฆ ๋กœ์ง ์ถ”๊ฐ€: ํ˜„์žฌ ์‚ฌ์šฉ์ž๊ฐ€ ์ž‘์„ฑํ•œ ๊ธ€์— ๋Œ€ํ•œ ํˆฌํ‘œ ์‹œ๋„ ์‹œ ์Šค๋‚ต๋ฐ” ๋ฉ”์‹œ์ง€ ํ‘œ์‹œ("์ž์‹ ์˜ ๊ธ€์—๋Š” ํˆฌํ‘œํ•  ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค.") ํ›„ ํˆฌํ‘œ ์ค‘๋‹จ.
UploadScreen ์ž…๋ ฅ ๊ธฐ๋ฐ˜ ๋ฐฑ๋ฒ„ํŠผ ์ฒ˜๋ฆฌ
feature/upload/src/main/java/com/sseotdabwa/buyornot/feature/upload/ui/UploadContract.kt, feature/upload/src/main/java/com/sseotdabwa/buyornot/feature/upload/ui/UploadScreen.kt
UploadUiState์— hasInput ๊ณ„์‚ฐ ์†์„ฑ ์ถ”๊ฐ€(selectedImageUri, category, price, content ์ค‘ ํ•˜๋‚˜๋ผ๋„ ์ž…๋ ฅ ์‹œ true), BackHandler์—์„œ hasInput ๊ธฐ๋ฐ˜์œผ๋กœ ๋ฐฑ๋ฒ„ํŠผ ๋™์ž‘ ๋ถ„๊ธฐ(์ž…๋ ฅ ์žˆ์Œโ†’์ข…๋ฃŒ ๋‹ค์ด์–ผ๋กœ๊ทธ, ์ž…๋ ฅ ์—†์Œโ†’๋’ค๋กœ๊ฐ€๊ธฐ).

Estimated code review effort

๐ŸŽฏ 3 (Moderate) | โฑ๏ธ ~25 minutes

Possibly related PRs

Suggested labels

โœจ FEAT, ๐Ÿ’ช ๋™ํ˜„๋™ํ˜„๋™ํ˜„

Suggested reviewers

  • Imagine-Choi
โœจ Finishing Touches
  • ๐Ÿ“ Generate docstrings (stacked PR)
  • ๐Ÿ“ Generate docstrings (commit on current branch)
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/0.0.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant